UI: Fix slider component in global settings with Range type
#10187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10187 +/- ##
=========================================
Coverage 15.13% 15.13%
Complexity 11272 11272
=========================================
Files 5408 5408
Lines 473958 473958
Branches 57811 57811
=========================================
+ Hits 71721 71724 +3
+ Misses 394219 394217 -2
+ Partials 8018 8017 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
added a commit
that referenced
this pull request
Jan 20, 2025
* 4.20: Maintenance mode: Add host to deployment planner avoid list to fix local storage vm migration (#9892) Add project-user association normalization script to 4.20.1 upgrade (#10116) fix slider component for global settings of the range type (#10187) Clean up network permissions on account deletion (#10176)
rg9975
pushed a commit
to rg9975/cloudstack
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The slider component for global settings of
Rangetype is currently not working correctly. Its width is equal to0px, and operators can only set the settings values to 0 or 100%. This PR addresses this issue by fixing the slider's behavior, allowing operators to properly adjust the settings values using the component.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
I verified that global settings of
Rangetype can be modified using the slider component.