-
Notifications
You must be signed in to change notification settings - Fork 117
polish: Fix some inconsistencies in object names and messages #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general remark; user data, User data and User Data seem to be used interchangably. maybe cleanup?
also I suggest a global replace of "ACL rule" with "access rule"
About Network ACLs | ||
^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About Network ACLs | |
^^^^^^^^^^^^^^^^^^^^^^^ | |
About Network ACLs | |
^^^^^^^^^^^^^^^^^^ |
Creating ACLs | ||
^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating ACLs | |
^^^^^^^^^^^^^^^^^^ | |
Creating ACLs | |
^^^^^^^^^^^^^ |
Creating a Tier with Custom ACL | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a Tier with Custom ACL | |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
Creating a Tier with Custom ACL | |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
Assigning a Custom ACL to a Tier | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assigning a Custom ACL to a Tier | |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
Assigning a Custom ACL to a Tier | |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
Storing and accessing user data | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storing and accessing user data | |
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
Storing and accessing user data | |
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
@@ -343,4 +343,4 @@ IPv6 ACL rules for an IPv6 supported VPC Network Tier can be managed using Netwo | |||
.. |add-ipv6-acl-rule-form.png| image:: /_static/images/add-ipv6-acl-rule-form.png | |||
:alt: Add IPv6 ACL rule. | |||
.. |ipv6-acl-list.png| image:: /_static/images/ipv6-acl-list.png | |||
:alt: IPv6 ACL rule in Network ACL list. | |||
:alt: IPv6 ACL rule in Network ACL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:alt: IPv6 ACL rule in Network ACL. | |
:alt: IPv6 access rule in Network ACL. |
??
@blueorangutan docbuild |
@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/506. (QA-JID 358) |
Thanks for the review @DaanHoogland I’m not entirely convinced about using “access rule”. It feels like a more generic term and might be unclear without proper context. Other platforms, like AWS, use the term “ACL rules,” so I’d prefer to stick with that for clarity and consistency. |
@@ -41,7 +41,7 @@ Network mode indicates the mode with which the isolated network or VPC will oper | |||
There are two valid options | |||
|
|||
- NATTED. This is the default network mode of isolated networks. The VR of isolated networks and VPCs provides Source NAT services, as well as Static NAT, Load Balancer, Port Forwarding, Vpn if the network offering supports. | |||
- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported services are Dns, Dhcp, Userdata, Firewall (for isolated networks) and Network ACL (for vpc and vpc networks). | |||
- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported services are Dns, Dhcp, User data, Firewall (for isolated networks) and Network ACL (for vpc and vpc networks). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported services are Dns, Dhcp, User data, Firewall (for isolated networks) and Network ACL (for vpc and vpc networks). | |
- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports Source NAT, Static NAT, Load Balancer, Port Forwarding and VPN. The supported services are DNS, DHCP, User data, Firewall (for isolated networks) and Network ACL (for VPC and VPC networks). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -41,7 +41,7 @@ Network mode indicates the mode with which the isolated network or VPC will oper | |||
There are two valid options | |||
|
|||
- NATTED. This is the default network mode of isolated networks. The VR of isolated networks and VPCs provides Source NAT services, as well as Static NAT, Load Balancer, Port Forwarding, Vpn if the network offering supports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- NATTED. This is the default network mode of isolated networks. The VR of isolated networks and VPCs provides Source NAT services, as well as Static NAT, Load Balancer, Port Forwarding, Vpn if the network offering supports. | |
- NATTED. This is the default network mode of isolated networks. The VR of isolated networks and VPCs provides Source NAT services, as well as Static NAT, Load Balancer, Port Forwarding, VPN if the network offering supports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -55,7 +55,7 @@ VPN support No Yes | |||
Port forwarding Physical Physical and Virtual | |||
1:1 NAT Physical Physical and Virtual | |||
Source NAT No Physical and Virtual | |||
Userdata Yes Yes | |||
User data Yes Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User data Yes Yes | |
User data Yes Yes |
check column alignment with other columns text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@blueorangutan docbuild |
@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/506. (QA-JID 371) |
Documentation PR for apache/cloudstack#10856
ACL Lists
User data
📚 Documentation preview 📚: https://cloudstack-documentation--506.org.readthedocs.build/en/506/