Let gpstop error message about environment variable readable #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the environment variables COORDINATOR_DATA_DIRECTORY are not set correctly, the error message is meaningless
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi, @water32 welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
my-ship-it
reviewed
Aug 20, 2025
| coordinator_data_directory = os.getenv('COORDINATOR_DATA_DIRECTORY') | ||
| if coordinator_data_directory is None: | ||
| coordinator_data_directory = options.coordinatorDataDirectory | ||
| coordinator_data_directory = get_coordinatordatadir() |
There was a problem hiding this comment.
Also need to modify gpstart, gpstop, and etc
|
Hi @water32 thanks for your contribution! Could you please update the commit title and message body following our commit convention |
yjhjstz
approved these changes
Aug 20, 2025
water32
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the environment variables COORDINATOR_DATA_DIRECTORY are not set correctly, the error message is meaningless
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions