topology: replace token map with binary search #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not going to have every token in a map, instead binary search to find the closest host which owns the token. This remove the need to first binary search the tokenRing to find an actual token to lookup in the map. Fix SimpleStrategy not placing replicas on unique hosts. Dont return duplicate hosts from fallbacks from TokenAwarePolicy go fmt ./...
martin-sucha
added a commit
to kiwicom/gocql
that referenced
this pull request
Feb 5, 2020
This reverts commit 73f35ff.
martin-sucha
added a commit
to kiwicom/gocql
that referenced
this pull request
Feb 13, 2020
This reverts commit 73f35ff. Conflicts: policies.go policies_test.go topology.go
martin-sucha
added a commit
to kiwicom/gocql
that referenced
this pull request
Feb 14, 2020
This reverts commit 73f35ff.
martin-sucha
added a commit
to kiwicom/gocql
that referenced
this pull request
Feb 14, 2020
This reverts commit 73f35ff.
martin-sucha
added a commit
to kiwicom/gocql
that referenced
this pull request
Feb 14, 2020
This reverts commit 73f35ff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not going to have every token in a map, instead binary search to
find the closest host which owns the token. This remove the need to
first binary search the tokenRing to find an actual token to lookup in
the map.
Fix SimpleStrategy not placing replicas on unique hosts.
Dont return duplicate hosts from fallbacks from TokenAwarePolicy
go fmt ./...
updates #1349, #1316