Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing documentation of timeouts #1671

Closed
lcosmin opened this issue Feb 1, 2023 · 1 comment · Fixed by #1719
Closed

Confusing documentation of timeouts #1671

lcosmin opened this issue Feb 1, 2023 · 1 comment · Fixed by #1719

Comments

@lcosmin
Copy link

lcosmin commented Feb 1, 2023

What version of Cassandra are you using?

n/a

What version of Gocql are you using?

master branch @ 66ec152

What version of Go are you using?

n/a

What did you do?

n/a

What did you expect to see?

n/a

What did you see instead?

The documentation for Timeout is confusing, as it mentions ConnectionTimeout. It doesn't say what Timeout actually does.

@lcosmin lcosmin changed the title Confusing goclq documentation Confusing gocql documentation Feb 1, 2023
@martin-sucha martin-sucha changed the title Confusing gocql documentation Confusing documentation of timeouts Feb 1, 2023
@martin-sucha
Copy link
Contributor

Thanks for the report! Indeed the docs don't specify when exactly the timeouts apply.

martin-sucha added a commit to kiwicom/gocql that referenced this issue Feb 1, 2023
martin-sucha added a commit to kiwicom/gocql that referenced this issue Aug 28, 2023
Client timeouts need to be higher than server timeouts,
so that work does not accumulate on the server with retries.

This was not true by default, the gocql default timeout was lower
than the Cassandra default timeout.

Closes apache#1671
Closes apache#1701
martin-sucha added a commit to kiwicom/gocql that referenced this issue Aug 28, 2023
Client timeouts need to be higher than server timeouts,
so that work does not accumulate on the server with retries.

This was not true by default, the gocql default timeout was lower
than the Cassandra default timeout.

Closes apache#1671
Closes apache#1701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants