Batch create and accept stream#2754
Merged
chenBright merged 4 commits intoapache:masterfrom Oct 9, 2024
Merged
Conversation
Contributor
Author
|
看了下macos protobuf22 CI 编译的报错 但是也没有在编译时办法传入PROTOBUF_NO_THREADLOCAL宏,protobuf一个头文件做了检查,外部配置PROTOBUF_NO_THREADLOCAL宏就会报错 继续分析了下应该是protobuf的BUG,已经在MR protocolbuffers/protobuf#12983 修复, 但是protobuf@22.5版本没有包含该fix,导致在mac上只要在proto文件里使用repeated 类型的Field就会编译出错 |
wwbmmm
reviewed
Sep 4, 2024
Contributor
|
LGTM |
Contributor
Author
有空帮忙点下merge,多谢 |
chenBright
reviewed
Sep 9, 2024
d85b4db to
c881856
Compare
modify code based on the code review feedback and add more tests
c881856 to
58c392a
Compare
Contributor
Author
|
@chenBright @wwbmmm 大佬们有空帮忙点下merge |
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What problem does this PR solve?
Issue Number: #2733
Problem Summary: 支持一次RPC调用创建多个流
Side effects:
Performance effects(性能影响):
对批量创建stream场景有性能提升
Breaking backward compatibility(向后兼容性):
协议改动兼容,支持平滑升级
Check List: