Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify the checksum in bookie write path #1046

Open
sijie opened this issue Jan 24, 2018 · 2 comments
Open

verify the checksum in bookie write path #1046

sijie opened this issue Jan 24, 2018 · 2 comments

Comments

@sijie
Copy link
Member

sijie commented Jan 24, 2018

FEATURE REQUEST

  1. Please describe the feature you are requesting.

Current we only verify checksum on read path, but we don't verify checksum on write path. So a corrupted entry might be written to all replicas on write path (e.g. the message is corrupted at the source).

It is required to verify checksum in bookie write path before a bookie writes it.

  1. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

must-have

  1. Provide any additional detail on your proposed use case for this feature.

It becomes achievable after #1008

@karanmehta93
Copy link
Member

karanmehta93 commented Sep 25, 2019

Checkout https://quip.com/FmlEAnMbtjnU
@sijie @eolivelli Feel free to comment or add new ideas and your thoughts.
There are many more aspects to this which I will cover in other parts but this should be one start.

@Ghatage
Copy link
Contributor

Ghatage commented Oct 28, 2020

@karanmehta93 the checksum in the write path is a great addition. Can you contribute it to the community code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants