From a512b737160e7d52ed46964018c51302b2408967 Mon Sep 17 00:00:00 2001 From: Arvin Date: Wed, 24 Jan 2018 11:03:34 -0800 Subject: [PATCH] BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper Descriptions of the changes in this PR: Current the checksum implementation is in client module while the checksum semantic is more close to protocol. Moreover, moving the checksum implementation to protocol will avoid server module's dependency to client module when doing checksum in server side. Master Issue: #1007 Author: Arvin Reviewers: Enrico Olivelli , Sijie Guo , Venkateswararao Jujjuri This closes #1008 from ArvinDevel/BP_25_MovingChecksumToProto --- site/bps/BP-25-MovingChecksumToProto.md | 27 +++++++++++++++++++++++++ site/community/bookkeeper_proposals.md | 2 +- 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 site/bps/BP-25-MovingChecksumToProto.md diff --git a/site/bps/BP-25-MovingChecksumToProto.md b/site/bps/BP-25-MovingChecksumToProto.md new file mode 100644 index 00000000000..09f50196e7a --- /dev/null +++ b/site/bps/BP-25-MovingChecksumToProto.md @@ -0,0 +1,27 @@ +--- +title: "BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper" +issue: https://github.com/apache/bookkeeper/issues/1007 +state: "Accepted" +release: "N/A" +--- + +### Motivation + +Current the checksum implementation is in client module while the checksum semantic is more close to protocol. Moreover, moving the checksum implementation to protocol will avoid server module's dependency to client module when doing checksum in server side. + +### Public Interfaces + +An internal refactor not affecting public interfaces. + +### Proposed Changes + +Move the DigestManager and related classes to proto module + +### Compatibility, Deprecation, and Migration Plan +N/A + +### Test Plan +The original all tests should work as before. + +### Rejected Alternatives +N/A \ No newline at end of file diff --git a/site/community/bookkeeper_proposals.md b/site/community/bookkeeper_proposals.md index a918f9a9abe..2802c652dbe 100644 --- a/site/community/bookkeeper_proposals.md +++ b/site/community/bookkeeper_proposals.md @@ -85,7 +85,7 @@ using Google Doc. This section lists all the _bookkeeper proposals_ made to BookKeeper. -*Next Proposal Number: 23* +*Next Proposal Number: 26* ### Inprogress