Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task][Go SDK][Cleanup]: Migrate passert package exclusively to the generic register package. #27567

Open
1 of 15 tasks
lostluck opened this issue Jul 19, 2023 · 0 comments
Open
1 of 15 tasks

Comments

@lostluck
Copy link
Contributor

What needs to happen?

The go generate lines would need to be removed:
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/testing/passert/passert.go#L31

and the registrations in passert.shims.go https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/testing/passert/passert.shims.go should be moved to init() blocks using the register package instead.

Partially done in #27565, this will be easier to work on once prism is the default runner, since the error unregistered portions will be provided as test failures. See #24789

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant