Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task][Go SDK]: Update fhirio tests to not rely on direct runner. #27547

Open
2 of 15 tasks
lostluck opened this issue Jul 18, 2023 · 0 comments
Open
2 of 15 tasks

[Task][Go SDK]: Update fhirio tests to not rely on direct runner. #27547

lostluck opened this issue Jul 18, 2023 · 0 comments

Comments

@lostluck
Copy link
Contributor

lostluck commented Jul 18, 2023

What needs to happen?

The tests rely on overriding the GCP FHIR client with a test interface double, however, it hasn't been done in a serializable form, relying on the Direct Runner to not serialize the DoFns.

eg. https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/fhirio/deidentify.go#L85

https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/fhirio/common.go#L205

This is not a good testing style as it isn't possible to execute them on portable runners, like prism, flink, spark, dataflow etc.

Since this requires a bit more thought and code to resolve, fhirio will continue to use the direct runner as the default for now, but should be changed to an alternative testing means (possibly by a local GRPC connection or similar to a local fake of the service, setting the client endpoint to be overridden, with an API dialing option at client creation https://pkg.go.dev/google.golang.org/api/option#WithEndpoint)

https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/fhirio/common.go#L97

This is used for the native SpannerIO tests, as an example. https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/spannerio/common.go#L53

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant