Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Build RC and non-RC wheels in parallel. #27368

Open
1 of 15 tasks
Abacn opened this issue Jul 5, 2023 · 1 comment
Open
1 of 15 tasks

[Task]: Build RC and non-RC wheels in parallel. #27368

Abacn opened this issue Jul 5, 2023 · 1 comment

Comments

@Abacn
Copy link
Contributor

Abacn commented Jul 5, 2023

What happened?

code path: https://github.com/apache/beam/blob/master/.github/workflows/build_wheels.yml

There is exactly same steps "Build Wheel" and "Build RC wheels", both run the same command and produce same wheels with different naming:

8 wheels produced in 52 minutes:
  apache_beam-2.49.0-cp310-cp310-manylinux_2_17_i686.manylinux2014_i686.whl       13,728 kB
  apache_beam-2.49.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl   14,286 kB
  apache_beam-2.49.0-cp311-cp311-manylinux_2_17_i686.manylinux2014_i686.whl       14,585 kB
  apache_beam-2.49.0-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl   15,234 kB
  apache_beam-2.49.0-cp38-cp38-manylinux_2_17_i686.manylinux2014_i686.whl         14,369 kB
  apache_beam-2.49.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl     14,945 kB
  apache_beam-2.49.0-cp39-cp39-manylinux_2_17_i686.manylinux2014_i686.whl         13,999 kB
  apache_beam-2.49.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl     14,564 kB

8 wheels produced in 51 minutes:
  apache_beam-2.49.0rc1-cp310-cp310-manylinux_2_17_i686.manylinux2014_i686.whl       13,728 kB
  apache_beam-2.49.0rc1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl   14,286 kB
  apache_beam-2.49.0rc1-cp311-cp311-manylinux_2_17_i686.manylinux2014_i686.whl       14,585 kB
  apache_beam-2.49.0rc1-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl   15,234 kB
  apache_beam-2.49.0rc1-cp38-cp38-manylinux_2_17_i686.manylinux2014_i686.whl         14,369 kB
  apache_beam-2.49.0rc1-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl     14,945 kB
  apache_beam-2.49.0rc1-cp39-cp39-manylinux_2_17_i686.manylinux2014_i686.whl         13,999 kB
  apache_beam-2.49.0rc1-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl     14,564 kB

Example run:

https://github.com/apache/beam/actions/runs/5467460207/jobs/9953842597

This becomes extremely time consuming as linux-aarch64 wheels costs 2.5 h to run, then the workflow costs >5 h to run.

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn
Copy link
Contributor Author

Abacn commented Jul 6, 2023

Looking into the workflow yml, apache-beam and apache-beam-rc artifacts are slightly different, on the version numbers, which means it has to be built twice:

sed -i -e "s/${RELEASE_VERSION}/${RELEASE_VERSION}rc${RC_NUM}/g" apache_beam/version.py

Change this issue to FR

@Abacn Abacn changed the title [Bug]: release candidate wheels built twice on GitHub Action [Task]: Avoid build release candidate wheels twice on GitHub Action Jul 6, 2023
@Abacn Abacn added P3 and removed P2 labels Jul 6, 2023
@tvalentyn tvalentyn changed the title [Task]: Avoid build release candidate wheels twice on GitHub Action [Task]: Build RC and non-RC wheels in parallel. Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants