Skip to content
This repository was archived by the owner on Feb 16, 2024. It is now read-only.

Conversation

@lukasz-antoniak
Copy link
Member

As discussed in the JIRA ticket (https://issues.apache.org/jira/browse/BAHIR-183), revisited version of HDFS persistence of MQTT messages, which should ease recovery in case of device failure. The design discussion may be continued in JIRA, but I decided to open WIP PR for @yanlin-Lynn to review and comment.

@yanlin-Lynn
Copy link
Contributor

Sorry to keep you wait, I will review this PR in a few days.

@Brahim13brahim
Copy link

yes

@lresende
Copy link
Member

lresende commented Jun 8, 2019

@lukasz-antoniak what's the status of this pr, is this ready for final review/merge?

@lukasz-antoniak
Copy link
Member Author

@lresende, I would answer positive. This PR changes the way we implement HDFS persistence due to issues pointed out in JIRA commant.
@yanlin-Lynn, can you also have a look since I changed mostly the code you have introduced and worked on previously?

@yanlin-Lynn
Copy link
Contributor

@lresende, I would answer positive. This PR changes the way we implement HDFS persistence due to issues pointed out in JIRA commant.
@yanlin-Lynn, can you also have a look since I changed mostly the code you have introduced and worked on previously?

Very sorry to keep you wait. I will review it in weekends.


override def put(key: String, persistable: MqttPersistable): Unit = {
try {
val path = getPath(key)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just worry about the performance of creating a file for each coming message.

@yanlin-Lynn
Copy link
Contributor

And, I think we should better keep the ability to do flow-control, eg, control max number of message in each batch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants