From fc7f844a2d4251e9d298d7ac02725ee930fe1d8b Mon Sep 17 00:00:00 2001 From: Martin Tzvetanov Grigorov Date: Wed, 16 Oct 2024 10:38:09 +0300 Subject: [PATCH] Try with libicu-dev instead of DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 Signed-off-by: Martin Tzvetanov Grigorov --- .github/workflows/test-lang-csharp-ARM.yml | 12 ++++-------- .github/workflows/test-lang-csharp.yml | 12 ++++-------- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/.github/workflows/test-lang-csharp-ARM.yml b/.github/workflows/test-lang-csharp-ARM.yml index 4dcb496f887..554ee1a1e91 100644 --- a/.github/workflows/test-lang-csharp-ARM.yml +++ b/.github/workflows/test-lang-csharp-ARM.yml @@ -40,7 +40,7 @@ jobs: - name: Add libzstd shell: bash - run: sudo apt-get install -y libzstd-dev + run: sudo apt-get install -y libzstd-dev libicu-dev - name: Install .NET SDKs uses: actions/setup-dotnet@v4 @@ -63,9 +63,7 @@ jobs: run: ./build.sh lint - name: Test - run: | - export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 - ./build.sh test + run: ./build.sh test interop: runs-on: ubuntu-latest @@ -74,7 +72,7 @@ jobs: - name: Add libzstd shell: bash - run: sudo apt-get install -y libzstd-dev + run: sudo apt-get install -y libzstd-dev libicu-dev - name: Install .NET SDKs uses: actions/setup-dotnet@v4 @@ -125,9 +123,7 @@ jobs: run: ./build.sh interop-data-generate - name: Run Interop Tests - run: | - export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 - ./build.sh interop-data-test + run: ./build.sh interop-data-test arm64: name: C# on Linux ARM64 diff --git a/.github/workflows/test-lang-csharp.yml b/.github/workflows/test-lang-csharp.yml index b7d0a76c938..d5bc3bcb077 100644 --- a/.github/workflows/test-lang-csharp.yml +++ b/.github/workflows/test-lang-csharp.yml @@ -40,7 +40,7 @@ jobs: - name: Add libzstd shell: bash - run: sudo apt-get install -y libzstd-dev + run: sudo apt-get install -y libzstd-dev libicu-dev - name: Install .NET SDKs uses: actions/setup-dotnet@v4 @@ -63,9 +63,7 @@ jobs: run: ./build.sh lint - name: Test - run: | - export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 - ./build.sh test + run: ./build.sh test interop: runs-on: ubuntu-latest @@ -74,7 +72,7 @@ jobs: - name: Add libzstd shell: bash - run: sudo apt-get install -y libzstd-dev + run: sudo apt-get install -y libzstd-dev libicu-dev - name: Install .NET SDKs uses: actions/setup-dotnet@v4 @@ -125,6 +123,4 @@ jobs: run: ./build.sh interop-data-generate - name: Run Interop Tests - run: | - export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 - ./build.sh interop-data-test + run: ./build.sh interop-data-test