Skip to content

Conversation

@Tartarus0zm
Copy link
Contributor

@Tartarus0zm Tartarus0zm commented Nov 7, 2025

Which issue does this PR close?

Closes #1613 .

Rationale for this change

Currently, all extension functions in Auron are designed for Spark, Therefore, it is named SparkExtFunctions.
We are advancing multi-engine support for Auron, so the name SparkExtFunctions no longer meets our requirements.
Therefore, I suggest rename it to AuronExtFunctions.
Function Names for Native Implementations, I recommend using the following rules:

  • If it's only used by Auron and not integrated with other engines, then use standard naming conventions, such as Placeholder;
  • if used for spark should be start with 'Spark_', such as Spark_Murmur3Hash;
  • if used for flink should be start with 'Flink_', such as Flink_UNIX_TIMESTAMP;
  • same to other engines.

What changes are included in this PR?

  • rename SparkExtFunctions to AuronExtFunctions
  • add prefix of Spark_ for spark native functions

Are there any user-facing changes?

No.

How was this patch tested?

Test via CI

@Tartarus0zm
Copy link
Contributor Author

@richox @SteNicholas @zuston @merrily01 CI is green, PTAL

Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@merrily01 merrily01 merged commit c7240b2 into apache:master Nov 10, 2025
98 of 99 checks passed
@merrily01
Copy link
Member

Merged. Thanks @Tartarus0zm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce AuronExtFunctions

4 participants