ARROW-1387: [C++] Set up GPU leaf library, add unit test module for CUDA tests #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sklam |
…vice Change-Id: I40e6b5d77f895d7803dfad64dd9fc2d9f882c0f3
Change-Id: Ib07611064711a320527325224e8005e7142f062e
|
+1 |
xhochy
reviewed
Aug 22, 2017
| typename std::conditional<std::is_base_of<DataType, T>::value, T, \ | ||
| typename detail::GetAttr_TypeClass<T>::type>::type; \ | ||
| using c_type = typename detail::GetAttr_c_type<TypeClass>::type; | ||
| using c_type = typename detail::GetAttr_c_type<TypeClass>::type |
There was a problem hiding this comment.
Accidential deletion of the semicolon?
There was a problem hiding this comment.
This was on purpose because this macro is used like a function below (PRIMITIVE_TRAITS(...);). When this file gets touched by nvcc it caused clang to spew a bunch of warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional leaf library for users who want to use Arrow data on graphics cards. See parent JIRA ARROW-1055 for a roadmap for some basic GPU extensions