-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ARROW-1040: [GLib] Support tensor IO #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wesm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
I presume you're creating JIRAs with a script? Would you mind setting the assignee and fix version when you do? Thanks |
No. I'm creating JIRA issues by hand. :<
OK. I'll do. |
|
Ah, it seemed so orderly I thought computer-generated =) With http://jira.readthedocs.io/en/latest/examples.html#issues we can create issues easily (similar to the merge PR script and changelog scripts) if that becomes useful |
|
Thanks for the information. |
Author: Kouhei Sutou <kou@clear-code.com> Closes apache#697 from kou/glib-support-tensor-io and squashes the following commits: eca2c3f [Kouhei Sutou] [GLib] Support tensor IO
Based on changes from apache#41731. Added writer ExtensionWriter with 3 methods: - write method for writing values from Extension holders; - writeExtensionType method for writing values (arguments is Object because we don't know exact type); - addExtensionTypeFactory method - because the exact vector and value type are unknown, the user should create their own extension type vector, write for it, and ExtensionTypeFactory, which should map the vector and writer. Closes dremio#87. Co-authored-by: Finn Völkel <finn.volkel@gmail.com>
* GH-87: [Vector] Add ExtensionWriter (apache#697) Based on changes from apache#41731. Added writer ExtensionWriter with 3 methods: - write method for writing values from Extension holders; - writeExtensionType method for writing values (arguments is Object because we don't know exact type); - addExtensionTypeFactory method - because the exact vector and value type are unknown, the user should create their own extension type vector, write for it, and ExtensionTypeFactory, which should map the vector and writer. Closes #87. Co-authored-by: Finn Völkel <finn.volkel@gmail.com> * just checking * Update Brewfile * revert * Fix for Cmake 3.xx installation * Fix for Cmake 3.xx installation * update thrift * update thrift url * update thrift url * Update github.yml * fix format --------- Co-authored-by: Finn Völkel <finn.volkel@gmail.com>
* GH-87: [Vector] Add ExtensionWriter (apache#697) missed file
updated UnionListWriter.
* GH-87: [Vector] Add ExtensionWriter (apache#697) missed file * GH-87: [Vector] Add ExtensionWriter (apache#697) missed file * GH-87: [Vector] Add ExtensionWriter (apache#697) updated UnionListWriter.
Based on changes from apache#41731. ## What's Changed Added writer ExtensionWriter with 3 methods: - write method for writing values from Extension holders; - writeExtensionType method for writing values (arguments is Object because we don't know exact type); - addExtensionTypeFactory method - because the exact vector and value type are unknown, the user should create their own extension type vector, write for it, and ExtensionTypeFactory, which should map the vector and writer. Closes apache#87. Co-authored-by: Finn Völkel <finn.volkel@gmail.com>
No description provided.