-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48277: [C++][Parquet] unpack with shuffle algorithm #47994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
d2743d4 to
6e72467
Compare
a7e4cd9 to
9efa59a
Compare
d01fdba to
b28ea9b
Compare
|
|
f546ed9 to
4f9fbe1
Compare
|
@pitrou apart from R-lint, this is looking pretty good. |
|
@ursabot please benchmark lang=C++ |
|
Benchmark runs are scheduled for commit a4bfe8a. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
|
Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit a4bfe8a. There were 37 benchmark results indicating a performance regression:
The full Conbench report has more details. |
|
@pitrou I'm running this locally, and I made an error when fixing ASAN over-reading problem. |
a4bfe8a to
dd3ec0d
Compare
|
@ursabot please benchmark lang=C++ |
|
Benchmark runs are scheduled for commit dd3ec0d. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
|
Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit dd3ec0d. There were 19 benchmark results indicating a performance regression:
The full Conbench report has more details. |
|
@ursabot please benchmark lang=C++ |
|
Benchmark runs are scheduled for commit 408ef04. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
|
@ursabot please benchmark lang=C++ |
|
Thanks for your patience. Conbench analyzed the 0 benchmarking runs that have been run so far on PR commit 408ef04. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
|
Thanks for your patience. Conbench analyzed the 0 benchmarking runs that have been run so far on PR commit 408ef04. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
70b0b8c to
8e7a758
Compare
5bec80d to
3d623a4
Compare
3d623a4 to
2f99ce0
Compare
Rationale for this change
What changes are included in this PR?
The
constexprcode generation creates a kernel appropriate for a given input/output bit width and simd size.xsimdfallback that have been merged upstream.xsimdrelease.Are these changes tested?
Yes
Are there any user-facing changes?
No