GH-46754: [SWIFT] Add support for Timestamp data type #46753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
mgrazianoc
changed the title
|
|
|
|
|
We're moving the Swift implementation to https://github.com/apache/arrow-swift from apache/arrow. Could you open a PR on apache/arrow-swift not here? |
|
Yes, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently, the Swift implementation of Arrow does not support Timestamp, although they are available in the base C interface. This PR attempts to add its support by following the current implemented design pattern.
What changes are included in this PR?
TimestampArraywith some basic formatting utilitiesTimestampArrayBuilderTimestampaliasArrowTimestampUnit, which includes extensively all the variants (seconds, milliseconds, microseconds and nanoseconds)ArrowTypeTimestampfrom baseArrowArrowTypesupport for timestampArrowWriterHelpersupport for timestampfromProtosupport for timestampIt properly handles the presence or absence of
timezone.Are these changes tested?
Tests are included in both
ArrayTests.swiftandCDataTests.swift.Are there any user-facing changes?
Yes - users can now work with Timestamp data types in Swift Arrow implementations. This is additive and doesn't break existing functionality.