Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Nov 13, 2024

Rationale for this change

SO versions must be computed from the target version instead of embedding them to dev/tasks/tasks.yaml. Because they depend on the specified version as an argument.

What changes are included in this PR?

Add so_version variable that can be used in dev/tasks/tasks.yml.

Are these changes tested?

Yes.

#44699 (comment) used this.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #44706 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 13, 2024
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kou !

While this is definitely useful for future releases. We could just run for the current RC the binaries from the RC branch, right?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Nov 13, 2024
@kou
Copy link
Member Author

kou commented Nov 13, 2024

Right!

@raulcd raulcd merged commit d7bc378 into apache:main Nov 13, 2024
8 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Nov 13, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d7bc378.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

@kou kou deleted the release-binary-submit-so-version branch November 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants