GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running

[mroz45]

What changes are included in this PR?

I add checking joinable before join process_thread. It will prevent exeptions in case when plan is invalid and asof_join never_starts.

• GitHub Issue: [C++] Missing joinable check for thread in AsofJoinNode Destructor #44526

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - Contributing Overview

[github-actions]

⚠️ GitHub issue #44526 has been automatically assigned in GitHub to PR creator.

[zanmato1984]

Hi @mroz45 , thanks for fixing this!

I think we still need a reproducible C++ UT. If you have any difficulties on that, please let me know.

[mroz45]

@zanmato1984
Do you think this test is enough?

[zanmato1984]

@zanmato1984 Do you think this test is enough?

Thank you for the update. The test should suffice at my first glance. I'll take a deeper look soon.

[zanmato1984]

Let's keep the blank lines around individual tests.

[zanmato1984]

Some nits. Otherwise LGTM.

[zanmato1984]

Suggested change

	/*schema*/ nullptr};
	/*schema=*/nullptr};

[zanmato1984]

+1

I'll keep this PR open for another few days to see if @westonpace @pitrou have any comments. After that I'll merge this.

[pitrou]

Just a naming fix, otherwise LGTM

[zanmato1984]

Merged. Thank you @mroz45 for fixing this!

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit cf10b40.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

[kou]

@zanmato1984 Could you use our merge script https://github.com/apache/arrow/tree/main/dev#how-to-merge-a-pull-request next time? It removes comments (<!-- ... -->) from PR description and use the prepared PR description as a commit message.

[zanmato1984]

@zanmato1984 Could you use our merge script main/dev#how-to-merge-a-pull-request next time? It removes comments (<!-- ... -->) from PR description and use the prepared PR description as a commit message.

Thank you for reminding, I'll read the instruction and use it next time. And sorry for the trouble.