Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44246: [JS] encourage more efficient APIs in the examples #44292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Oct 3, 2024

@swallez
Copy link
Member

swallez commented Oct 3, 2024

New section looks nice, but what about moving it at the top so that people see it first, and then have the row iterator and array examples be clearly marked as "if you need to access to rows [as objects]" to further outline that this is provided as a convenience?

@domoritz
Copy link
Member Author

domoritz commented Oct 3, 2024

I changed the array example to use [...table] but only for the console.table example. Right below we now show how to access the column vectors. I think that's pretty immediate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants