ARROW-347: Add method to pass CallBack when creating a transfer pair #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. +1 |
Member
|
Merging. C++ failure caused by PARQUET-919 (patch available) |
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
…s Clang warnings These warnings will catch a number of things that have bitten us in the past, like missing virtual destructors. This brings Parquet's compiler warnings up to the same quality as Arrow's Author: Wes McKinney <wes.mckinney@twosigma.com> Author: Wes McKinney <wesmckinn@gmail.com> Closes apache#425 from wesm/PARQUET-1177 and squashes the following commits: 3769a8c [Wes McKinney] Add -Wno-missing-noreturn 5b6cd80 [Wes McKinney] Compile with /bigobj in MSVC cc5bca0 [Wes McKinney] Add noreturn to static methods in ParquetException e3ffb71 [Wes McKinney] Fix -Wconversion warnings in decode_benchmark.cc 758a216 [Wes McKinney] Fix warnings on macOS Clang 3aef3b4 [Wes McKinney] Do not pass -Werror via PARQUET_CXXFLAGS 5a98e81 [Wes McKinney] Fix usage of PrimitiveArray::raw_values c848855 [Wes McKinney] Fix compiler warnings with gcc 4.9 ca9a374 [Wes McKinney] Add SetupCxxFlags.cmake from Apache Arrow. Add PARQUET_BUILD_WARNING_LEVEL flag. Fix Clang compiler warnings Change-Id: I803c88e1ca5df33593405fdace786bf5a57d9d6b
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 27, 2018
…s Clang warnings These warnings will catch a number of things that have bitten us in the past, like missing virtual destructors. This brings Parquet's compiler warnings up to the same quality as Arrow's Author: Wes McKinney <wes.mckinney@twosigma.com> Author: Wes McKinney <wesmckinn@gmail.com> Closes apache#425 from wesm/PARQUET-1177 and squashes the following commits: 3769a8c [Wes McKinney] Add -Wno-missing-noreturn 5b6cd80 [Wes McKinney] Compile with /bigobj in MSVC cc5bca0 [Wes McKinney] Add noreturn to static methods in ParquetException e3ffb71 [Wes McKinney] Fix -Wconversion warnings in decode_benchmark.cc 758a216 [Wes McKinney] Fix warnings on macOS Clang 3aef3b4 [Wes McKinney] Do not pass -Werror via PARQUET_CXXFLAGS 5a98e81 [Wes McKinney] Fix usage of PrimitiveArray::raw_values c848855 [Wes McKinney] Fix compiler warnings with gcc 4.9 ca9a374 [Wes McKinney] Add SetupCxxFlags.cmake from Apache Arrow. Add PARQUET_BUILD_WARNING_LEVEL flag. Fix Clang compiler warnings Change-Id: I428d1d90bc4eb3dab8b56a538d1eb58656664b74
wesm
added a commit
that referenced
this pull request
Sep 27, 2018
…s Clang warnings These warnings will catch a number of things that have bitten us in the past, like missing virtual destructors. This brings Parquet's compiler warnings up to the same quality as Arrow's Author: Wes McKinney <wes.mckinney@twosigma.com> Author: Wes McKinney <wesmckinn@gmail.com> Closes #425 from wesm/PARQUET-1177 and squashes the following commits: 3769a8c [Wes McKinney] Add -Wno-missing-noreturn 5b6cd80 [Wes McKinney] Compile with /bigobj in MSVC cc5bca0 [Wes McKinney] Add noreturn to static methods in ParquetException e3ffb71 [Wes McKinney] Fix -Wconversion warnings in decode_benchmark.cc 758a216 [Wes McKinney] Fix warnings on macOS Clang 3aef3b4 [Wes McKinney] Do not pass -Werror via PARQUET_CXXFLAGS 5a98e81 [Wes McKinney] Fix usage of PrimitiveArray::raw_values c848855 [Wes McKinney] Fix compiler warnings with gcc 4.9 ca9a374 [Wes McKinney] Add SetupCxxFlags.cmake from Apache Arrow. Add PARQUET_BUILD_WARNING_LEVEL flag. Fix Clang compiler warnings Change-Id: I428d1d90bc4eb3dab8b56a538d1eb58656664b74
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
supersedes and closes apache#182 Author: Julien Le Dem <julien@dremio.com> Closes apache#425 from julienledem/arrow_347 and squashes the following commits: 3c47b82 [Julien Le Dem] ARROW-347: Add method to pass CallBack when creating a transfer pair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes and closes #182