GH-39675: [C++][FlightRPC] Expose additional RPC call info to middleware #39678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Exposes more gRPC call information to middleware APIs for better traces and debugging
What changes are included in this PR?
ServerMiddlewareto be invoked after protobuf messsages are receivedcode.functionspan attribute inTracingServerMiddlewareforDoActionmethods (based on OTel semantic conventions doc, but warrants double-checking)Are these changes tested?
Ad hoc only. Proper tests are WIP
Are there any user-facing changes?
Yes