-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-38007: [C++] Add VariableShapeTensor implementation #38008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
eec16ec to
6287402
Compare
dff5441 to
9c3b464
Compare
|
Hi @rok! It would be great to have this in 15.0.0 (added the milestone for visibility). Do you think you have enough bandwidth to work on it at the moment? |
|
@AlenkaF yes I'd very much like to continue working on this, I was waiting for the release before chasing reviewers :D |
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@pimdh Yes, that seems right. |
|
Given that there is some interest in using VariableShapeTensor and that it was already implemented in rust it might make sense to merge this PR. @pitrou would you happen to have time to take another look here? |
No, as I didn't yet run into any limits of the int32 arrays, I have no need for the large version. |
Rationale for this change
We want to add VariableShapeTensor extension type definition for arrays containing tensors with variable shapes.
What changes are included in this PR?
This adds a C++ implementation.
Are these changes tested?
Yes.
Are there any user-facing changes?
This adds a new extension type C++.