ARROW-556: [Integration] Fix integration tests if using alternate cpp build path #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix seemed best to me because the current instructions would still be valid and only require the user to export ARROW_CPP_TESTER. Alternatively, the user could export CPP_BUILD_DIR and then use that to point to the |
|
I prefer the changes in #340 but let me know what you think |
|
You're too fast! :) |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Fixes #6. --------- Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to integration tests will extract cpp build path from ARROW_CPP_TESTER env var if it is set. If not set then use a default value for the build path and assign ARROW_CPP_TESTER using that path.