Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3668: [R} Namespace dependency bit64 is not required #2888

Closed
wants to merge 1 commit into from
Closed

ARROW-3668: [R} Namespace dependency bit64 is not required #2888

wants to merge 1 commit into from

Conversation

jameslamb
Copy link
Contributor

The R package is currently broken on Travis because dependency bit64 was recently added but put in Suggests instead of Imports.

image

In R, every package that you add as an import or importFrom in your NAMESPACE file needs to be in Imports or Depends in DESCRIPTION.

Please consider this PR to address this.

@jameslamb jameslamb changed the title ARROW-3668: Namespace dependency bit64 is not required [R] ARROW-3668: Namespace dependency bit64 is not required Nov 1, 2018
@jameslamb jameslamb changed the title [R] ARROW-3668: Namespace dependency bit64 is not required ARROW-3668: [R} Namespace dependency bit64 is not required Nov 1, 2018
@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

Merging #2888 into master will increase coverage by 1.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2888     +/-   ##
=========================================
+ Coverage   87.33%   88.44%   +1.1%     
=========================================
  Files         417      348     -69     
  Lines       64900    59597   -5303     
=========================================
- Hits        56678    52708   -3970     
+ Misses       8128     6889   -1239     
+ Partials       94        0     -94
Impacted Files Coverage Δ
rust/src/record_batch.rs
go/arrow/array/table.go
rust/src/array.rs
go/arrow/math/uint64_amd64.go
go/arrow/internal/testing/tools/bool.go
go/arrow/array/bufferbuilder.go
go/arrow/internal/bitutil/bitutil.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/array/null.go
go/arrow/datatype_nested.go
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbbffa...afe3120. Read the comment docs.

@kszucs
Copy link
Member

kszucs commented Nov 1, 2018

Actually this is already resolved by #2876

@kszucs
Copy link
Member

kszucs commented Nov 1, 2018

So I'm closing as a duplicate. However thanks @jameslamb for the fix!

@kszucs kszucs closed this Nov 1, 2018
@jameslamb
Copy link
Contributor Author

Ah sorry, didn't realize! No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants