ARROW-3668: [R} Namespace dependency bit64 is not required#2888
Closed
jameslamb wants to merge 1 commit intoapache:masterfrom
jameslamb:bugfix/r_deps
Closed
ARROW-3668: [R} Namespace dependency bit64 is not required#2888jameslamb wants to merge 1 commit intoapache:masterfrom jameslamb:bugfix/r_deps
jameslamb wants to merge 1 commit intoapache:masterfrom
jameslamb:bugfix/r_deps
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2888 +/- ##
=========================================
+ Coverage 87.33% 88.44% +1.1%
=========================================
Files 417 348 -69
Lines 64900 59597 -5303
=========================================
- Hits 56678 52708 -3970
+ Misses 8128 6889 -1239
+ Partials 94 0 -94Continue to review full report at Codecov.
|
Member
|
Actually this is already resolved by #2876 |
Member
|
So I'm closing as a duplicate. However thanks @jameslamb for the fix! |
Contributor
Author
|
Ah sorry, didn't realize! No worries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The R package is currently broken on Travis because dependency
bit64was recently added but put inSuggestsinstead ofImports.In R, every package that you add as an
importorimportFromin yourNAMESPACEfile needs to be inImportsorDependsinDESCRIPTION.Please consider this PR to address this.