ARROW-1754: [Python] Fix buggy Parquet roundtrip when an index name is the same as a column name #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the same as a column name
|
thanks @cpcloud! |
|
Yes! |
This was referenced Nov 19, 2017
wesm
pushed a commit
that referenced
this pull request
Feb 2, 2018
…that preserves index name if available Related to the discussion about the pandas metadata specification in pandas-dev/pandas#18201, and an alternative to #1271. I don't open this PR because it should necessarily be merged, I just want to show that it is not that difficult to both fix [ARROW-1754](https://issues.apache.org/jira/browse/ARROW-1754) and preserve index names as field names when possible (as this was mentioned in pandas-dev/pandas#18201 as the reason to make this change to not preserve index names). The diff is partly a revert of #1271, but then adapted to the current codebase. Main reasons I prefer to preserve index names: 1) usability in pyarrow itself (if you would want to work with pyarrow Tables created from pandas) and 2) when interchanging parquet files with other people / other non-pandas systems, then it would be much nicer to not have `__index_level_n__` column names if possible. Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Closes #1408 from jorisvandenbossche/index-names and squashes the following commits: eef1d33 [Joris Van den Bossche] alternative fix for duplicate index/column name that preserves index name if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.