ARROW-12716: [C++] Add string padding kernel #10586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done (also set the default pad character to ' ' to be nicer to Python users). |
pitrou
reviewed
Jun 24, 2021
| @@ -93,19 +93,23 @@ struct BinaryLength { | |||
| } | |||
| }; | |||
|
|
|||
| template <typename OffsetValue> | |||
| OffsetValue CountCodepoints(const uint8_t* str, size_t strlen) { | |||
There was a problem hiding this comment.
There's no need to template this on OffsetValue, just return int64_t.
Also, since this is a generally useful function, perhaps put it in arrow/util/utf8.h?
There was a problem hiding this comment.
Moved & added a small test case.
|
|
||
| int64_t Transform(const uint8_t* input, int64_t input_string_ncodeunits, | ||
| uint8_t* output) { | ||
| // XXX input_string_ncodeunits is misleading - it's just bytes |
There was a problem hiding this comment.
"codeunits" is the same as bytes for UTF8 ("codeunits" as opposed to "codepoints").
But, yes, it's pointlessly pedantic. Perhaps a wholesale renaming would be useful.
There was a problem hiding this comment.
Argh, somehow I had thought a codeunit was an encoded codepoint (i.e. 1-4 bytes). I'll remove the comment at least so as not to be misleading.
cyb70289
reviewed
Jun 28, 2021
cyb70289
reviewed
Jun 28, 2021
pitrou
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.