[C++] c++23 supported?

[BwL1289]

Describe the usage question you have. Please include as many useful details as possible.

Is c++23 supported? We forked arrow a number of months ago to support compiling with c++20 and c++23, and would prefer to deprecate our fork if possible.

Here's the diff.

Component(s)

C++

[kou]

We want to support both of C++20 and C++23 if possible.
Could you break down needed tasks for C++23 support and open smaller PRs for them instead of one large PR? It's for easy to review.

[BwL1289]

@kou I'm happy to help. PRs for each file may be best, but I will defer to you. Most of the changes have o do with forward declarations. cpp/src/arrow/acero/asof_join_node.cc has the most changes.

[kou]

OK. Let's try one issue/PR per file. Could you open subissues? Let's fix them one by one.

As the first step, let's add a CI job for C++23 that accepts build failure for now. We'll remove the "accepts build failure" in the last PR.

[BwL1289]

@kou it doesn't look like we can create sub-issues (not sure if we have insufficient permissions) but while trying to follow these directions, there is no "create subissue" option.

[kou]

OK. Could you create subissues as normal issues? I'll set associations later.

[BwL1289]

@kou we finished syncing with upstream and testing compilation locally. All works with c++23.

Unfortunately we discussed internally (we're a very small 3 person team) and breaking this up into 4 different PRs is going to be a lot of extra work for us.

Any chance you're open to us just opening a single PR?

[kou]

It's a large single PR, right...?

You can open a single PR but I may not be able to review/merge it. Others may be able to review/merge it...