Return Status::IOError instead of DCHECK if message header type is not matched

mrkn · mrkn · commit f78230344de9 · 2019-01-09T17:53:29.000+09:00
diff --git a/cpp/src/arrow/ipc/metadata-internal.cc b/cpp/src/arrow/ipc/metadata-internal.cc
@@ -1041,7 +1041,7 @@ Status GetSparseTensorMetadata(const Buffer& metadata, std::shared_ptr<DataType>
                                SparseTensorFormat::type* sparse_tensor_format_id) {
   auto message = flatbuf::GetMessage(metadata.data());
   if (message->header_type() != flatbuf::MessageHeader_SparseTensor) {
-    DCHECK_EQ(message->header_type(), flatbuf::MessageHeader_SparseTensor);
+    return Status::IOError("Header of flatbuffer-encoded Message is not SparseTensor.");
   }
   if (message->header() == nullptr) {
     return Status::IOError("Header-pointer of flatbuffer-encoded Message is null.");

Original file line number	Diff line number	Diff line change
`@@ -1041,7 +1041,7 @@ Status GetSparseTensorMetadata(const Buffer& metadata, std::shared_ptr<DataType>`
`1041`	`1041`	`SparseTensorFormat::type* sparse_tensor_format_id) {`
`1042`	`1042`	`auto message = flatbuf::GetMessage(metadata.data());`
`1043`	`1043`	`if (message->header_type() != flatbuf::MessageHeader_SparseTensor) {`
`1044`		`- DCHECK_EQ(message->header_type(), flatbuf::MessageHeader_SparseTensor);`
	`1044`	`+ return Status::IOError("Header of flatbuffer-encoded Message is not SparseTensor.");`
`1045`	`1045`	`}`
`1046`	`1046`	`if (message->header() == nullptr) {`
`1047`	`1047`	`return Status::IOError("Header-pointer of flatbuffer-encoded Message is null.");`