Install type_traits.h. cpplint

Change-Id: I008bf0adc806034062d6684fd1615448db246c6b

Author: wesm

cpp/src/arrow/CMakeLists.txt

@@ -25,6 +25,7 @@ install(FILES
   table.h
   type.h
   type_fwd.h
+  type_traits.h
   test-util.h
   DESTINATION include/arrow)
 

cpp/src/arrow/ipc/json-internal.cc

@@ -21,6 +21,7 @@
 #include <sstream>
 #include <string>
 #include <type_traits>
+#include <vector>
 
 #include "rapidjson/stringbuffer.h"
 #include "rapidjson/writer.h"
@@ -53,7 +54,7 @@ static std::string GetBufferTypeName(BufferType type) {
       return "VALIDITY";
     default:
       break;
-  };
+  }
   return "UNKNOWN";
 }
 
@@ -149,7 +150,7 @@ class JsonSchemaWriter : public TypeVisitor {
         break;
       default:
         break;
-    };
+    }
   }
 
   template <typename T>
@@ -163,7 +164,7 @@ class JsonSchemaWriter : public TypeVisitor {
       case IntervalType::Unit::DAY_TIME:
         writer_->String("DAY_TIME");
         break;
-    };
+    }
   }
 
   template <typename T>
@@ -185,7 +186,7 @@ class JsonSchemaWriter : public TypeVisitor {
       case TimeUnit::NANO:
         writer_->String("NANOSECOND");
         break;
-    };
+    }
   }
 
   template <typename T>
@@ -208,7 +209,7 @@ class JsonSchemaWriter : public TypeVisitor {
       case UnionMode::DENSE:
         writer_->String("DENSE");
         break;
-    };
+    }
 
     // Write type ids
     writer_->Key("typeIds");
@@ -788,7 +789,6 @@ class JsonSchemaReader {
     } else {
       std::stringstream ss;
       ss << "Invalid union mode: " << mode_str;
-      ;
       return Status::Invalid(ss.str());
     }
 
@@ -1013,7 +1013,7 @@ class JsonArrayReader {
         std::stringstream ss;
         ss << type->ToString();
         return Status::NotImplemented(ss.str());
-    };
+    }
 
 #undef TYPE_CASE
 #undef NOT_IMPLEMENTED_CASE

cpp/src/arrow/ipc/json-internal.h

@@ -25,6 +25,7 @@
 #define RAPIDJSON_HAS_CXX11_RANGE_FOR 1
 
 #include <memory>
+#include <string>
 
 #include "rapidjson/document.h"
 #include "rapidjson/stringbuffer.h"

cpp/src/arrow/ipc/json.cc

@@ -15,15 +15,9 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include "arrow/ipc/json-internal.h"
-
-#define RAPIDJSON_HAS_STDSTRING 1
-#define RAPIDJSON_HAS_CXX11_RVALUE_REFS 1
-#define RAPIDJSON_HAS_CXX11_RANGE_FOR 1
-
-#include "rapidjson/stringbuffer.h"
-#include "rapidjson/writer.h"
+#include "arrow/ipc/json.h"
 
+#include "arrow/ipc/json-internal.h"
 #include "arrow/type.h"
 #include "arrow/util/status.h"
 

cpp/src/arrow/ipc/json.h

@@ -21,6 +21,7 @@
 #define ARROW_IPC_JSON_H
 
 #include <memory>
+#include <vector>
 
 #include "arrow/type_fwd.h"
 #include "arrow/visibility.h"
@@ -79,7 +80,7 @@ class ARROW_EXPORT JsonReader {
   Status GetRecordBatch(int i, std::shared_ptr<RecordBatch>* batch);
 
  private:
-  JsonReader(const std::shared_ptr<io::ReadableFileInterface>& file);
+  explicit JsonReader(const std::shared_ptr<io::ReadableFileInterface>& file);
 
   std::shared_ptr<io::ReadableFileInterface> file_;
   std::shared_ptr<Schema> schema_;