Skip to content

Commit e12d285

Browse files
pitroukou
authored andcommitted
ARROW-6742: [C++] Remove boost::filesystem dependency in hdfs_internal.cc
Closes #6062 from pitrou/ARROW-6742-hdfs-boost-fs and squashes the following commits: 250178e <Antoine Pitrou> ARROW-6742: Remove boost::filesystem dependency in hdfs_internal.cc Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 parent b7352f1 commit e12d285

File tree

4 files changed

+145
-155
lines changed

4 files changed

+145
-155
lines changed

.github/workflows/cpp.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ jobs:
9999
# TODO(kszucs): link error in the tests
100100
ARROW_ORC: OFF
101101
ARROW_FLIGHT: ON
102+
ARROW_HDFS: ON
102103
ARROW_PLASMA: ON
103104
ARROW_GANDIVA: ON
104105
ARROW_PARQUET: ON
@@ -143,6 +144,7 @@ jobs:
143144
CMAKE_INSTALL_PREFIX: /usr
144145
ARROW_HOME: /usr
145146
ARROW_FLIGHT: OFF
147+
ARROW_HDFS: ON
146148
ARROW_PARQUET: OFF
147149
ARROW_WITH_ZLIB: OFF
148150
ARROW_WITH_LZ4: OFF

cpp/CMakeLists.txt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -679,10 +679,8 @@ endif()
679679

680680
set(ARROW_SHARED_PRIVATE_LINK_LIBS ${ARROW_STATIC_LINK_LIBS})
681681

682-
# boost::filesystem is needed for HDFS, and for S3 and Flight tests as a
683-
# boost::process dependency.
684-
if(((ARROW_FLIGHT OR ARROW_S3) AND (ARROW_BUILD_TESTS OR ARROW_BUILD_INTEGRATION))
685-
OR ARROW_HDFS)
682+
# boost::filesystem is needed for S3 and Flight tests as a boost::process dependency.
683+
if(((ARROW_FLIGHT OR ARROW_S3) AND (ARROW_BUILD_TESTS OR ARROW_BUILD_INTEGRATION)))
686684
set(ARROW_WITH_BOOST_FILESYSTEM ON)
687685

688686
list(APPEND ARROW_SHARED_PRIVATE_LINK_LIBS ${BOOST_FILESYSTEM_LIBRARY}

0 commit comments

Comments
 (0)