Skip to content

Commit de8389d

Browse files
committed
write line separator to output properly formatted jsonlines
1 parent 8b152b4 commit de8389d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

dev/archery/archery/cli.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,9 +352,12 @@ def benchmark_diff(ctx, src, preserve, suite_filter, benchmark_filter,
352352

353353
regressions = 0
354354
runner_comp = RunnerComparator(runner_cont, runner_base, threshold)
355+
356+
# TODO(kszucs): test that the output is properly formatted jsonlines
355357
for comparator in runner_comp.comparisons:
356358
regressions += comparator.regression
357359
json.dump(comparator, output, cls=JsonEncoder)
360+
output.write('\n')
358361

359362
sys.exit(regressions)
360363

0 commit comments

Comments
 (0)