Skip to content

Commit 960f0d2

Browse files
authored
MINOR: [C++] Remove obsolete todo about NaN handling at compare.cc (#48694)
### Rationale for this change 52d615d added this todo. https://github.com/apache/arrow/blob/52d615dc2cd64fbdbc10f2aeeb3b43ad5e879f3b/cpp/src/arrow/compare.cc#L64 After 4 years later, 72d20ad implemented the logic https://github.com/apache/arrow/blob/37c40fb789cdc87baab7faef217f02144e36d491/cpp/src/arrow/compare.cc#L92 https://github.com/apache/arrow/blob/37c40fb789cdc87baab7faef217f02144e36d491/cpp/src/arrow/compare.cc#L116 This is being tested in https://github.com/apache/arrow/blob/37c40fb789cdc87baab7faef217f02144e36d491/cpp/src/arrow/array/array_test.cc#L2314-L2316 ### What changes are included in this PR? This PR removes the obsolete todo about NaN handling at compare.cc. ### Are these changes tested? No, I did not test. ### Are there any user-facing changes? No. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 parent 245f067 commit 960f0d2

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

cpp/src/arrow/compare.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ using util::Float16;
7171

7272
namespace {
7373

74-
// TODO also handle HALF_FLOAT NaNs
75-
7674
template <bool Approximate, bool NansEqual, bool SignedZerosEqual>
7775
struct FloatingEqualityFlags {
7876
static constexpr bool approximate = Approximate;

0 commit comments

Comments
 (0)