Skip to content

Commit 8d708e2

Browse files
added mmap argument to all methods of feather_table_reader
1 parent fd1b7d5 commit 8d708e2

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

r/R/feather.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,12 @@ write_feather_RecordBatch <- function(data, stream) {
117117
#' @param ... extra parameters
118118
#'
119119
#' @export
120-
feather_table_reader <- function(file, ...){
120+
feather_table_reader <- function(file, mmap = TRUE, ...){
121121
UseMethod("feather_table_reader")
122122
}
123123

124124
#' @export
125-
feather_table_reader.default <- function(file, ...) {
125+
feather_table_reader.default <- function(file, mmap = TRUE, ...) {
126126
stop("unsupported")
127127
}
128128

@@ -138,12 +138,12 @@ feather_table_reader.fs_path <- function(file, mmap = TRUE, ...) {
138138
}
139139

140140
#' @export
141-
`feather_table_reader.arrow::io::RandomAccessFile` <- function(file, ...){
141+
`feather_table_reader.arrow::io::RandomAccessFile` <- function(file, mmap = TRUE, ...){
142142
unique_ptr(`arrow::ipc::feather::TableReader`, ipc___feather___TableReader__Open(file))
143143
}
144144

145145
#' @export
146-
`feather_table_reader.arrow::ipc::feather::TableReader` <- function(file){
146+
`feather_table_reader.arrow::ipc::feather::TableReader` <- function(file, mmap = TRUE, ...){
147147
file
148148
}
149149

r/man/feather_table_reader.Rd

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)