ARROW-7751: [Release] macOS wheel verification also needs arrow-testing

This addition follows the pattern of `test_source_distribution` (as it is in #6344). There are also two error message patches to make them consistent with everywhere else that references this env var (though FWIW `testing/data` is still not correct in the verification script, it's `arrow-testing/data` 🤷‍♂).

Closes #6345 from nealrichardson/flight-testing-data and squashes the following commits:

a29e88a <Krisztián Szűcs> factor out testing repository cloning
df9ef25 <Neal Richardson> Move addition and fix lint
e165d54 <Neal Richardson> Make sure macOS wheel verification has test data

Lead-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>

Author: nealrichardson

cpp/src/arrow/flight/test_util.cc

@@ -454,7 +454,8 @@ Status TestClientBasicAuthHandler::GetToken(std::string* token) {
 Status GetTestResourceRoot(std::string* out) {
   const char* c_root = std::getenv("ARROW_TEST_DATA");
   if (!c_root) {
-    return Status::IOError("Test resources not found, set ARROW_TEST_DATA");
+    return Status::IOError(
+        "Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data");
   }
   *out = std::string(c_root);
   return Status::OK();

dev/release/verify-release-candidate.sh

@@ -522,6 +522,18 @@ test_integration() {
               $INTEGRATION_TEST_ARGS
 }
 
+clone_testing_repositories() {
+  # Clone testing repositories if not cloned already
+  if [ ! -d "arrow-testing" ]; then
+    git clone https://github.com/apache/arrow-testing.git
+  fi
+  if [ ! -d "parquet-testing" ]; then
+    git clone https://github.com/apache/parquet-testing.git
+  fi
+  export ARROW_TEST_DATA=$PWD/arrow-testing/data
+  export PARQUET_TEST_DATA=$PWD/parquet-testing/data
+}
+
 test_source_distribution() {
   export ARROW_HOME=$TMPDIR/install
   export PARQUET_HOME=$TMPDIR/install
@@ -534,15 +546,7 @@ test_source_distribution() {
     NPROC=$(nproc)
   fi
 
-  # Clone testing repositories if not cloned already
-  if [ ! -d "arrow-testing" ]; then
-    git clone https://github.com/apache/arrow-testing.git
-  fi
-  if [ ! -d "parquet-testing" ]; then
-    git clone https://github.com/apache/parquet-testing.git
-  fi
-  export ARROW_TEST_DATA=$PWD/arrow-testing/data
-  export PARQUET_TEST_DATA=$PWD/parquet-testing/data
+  clone_testing_repositories
 
   if [ ${TEST_JAVA} -gt 0 ]; then
     test_package_java
@@ -668,6 +672,8 @@ test_macos_wheels() {
 }
 
 test_wheels() {
+  clone_testing_repositories
+
   local download_dir=binaries
   mkdir -p ${download_dir}
 

python/pyarrow/tests/test_flight.py

@@ -60,7 +60,7 @@ def resource_root():
     """Get the path to the test resources directory."""
     if not os.environ.get("ARROW_TEST_DATA"):
         raise RuntimeError("Test resources not found; set "
-                           "ARROW_TEST_DATA to <repo root>/testing")
+                           "ARROW_TEST_DATA to <repo root>/testing/data")
     return pathlib.Path(os.environ["ARROW_TEST_DATA"]) / "flight"