Add comments

Author: pitrou

cpp/cmake_modules/ThirdpartyToolchain.cmake

@@ -2062,6 +2062,7 @@ macro(build_substrait)
     # Missing dll-interface:
     list(APPEND SUBSTRAIT_SUPPRESSED_FLAGS "/wd4251")
   else()
+    # GH-44954: silence [[deprecated]] declarations in protobuf-generated code
     list(APPEND SUBSTRAIT_SUPPRESSED_FLAGS "-Wno-deprecated")
     if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR CMAKE_CXX_COMPILER_ID STREQUAL
                                                       "Clang")

cpp/src/arrow/engine/substrait/expression_internal.h

@@ -29,6 +29,7 @@
 #include "arrow/result.h"
 #include "arrow/util/macros.h"
 
+// GH-44954: silence [[deprecated]] declarations in protobuf-generated code
 ARROW_SUPPRESS_DEPRECATION_WARNING
 #include "substrait/algebra.pb.h"  // IWYU pragma: export
 ARROW_UNSUPPRESS_DEPRECATION_WARNING

cpp/src/arrow/engine/substrait/extended_expression_internal.h

@@ -30,6 +30,7 @@
 #include "arrow/status.h"
 #include "arrow/util/macros.h"
 
+// GH-44954: silence [[deprecated]] declarations in protobuf-generated code
 ARROW_SUPPRESS_DEPRECATION_WARNING
 #include "substrait/extended_expression.pb.h"  // IWYU pragma: export
 ARROW_UNSUPPRESS_DEPRECATION_WARNING

cpp/src/arrow/engine/substrait/plan_internal.h

@@ -29,6 +29,7 @@
 #include "arrow/status.h"
 #include "arrow/util/macros.h"
 
+// GH-44954: silence [[deprecated]] declarations in protobuf-generated code
 ARROW_SUPPRESS_DEPRECATION_WARNING
 #include "substrait/plan.pb.h"  // IWYU pragma: export
 ARROW_UNSUPPRESS_DEPRECATION_WARNING

cpp/src/arrow/engine/substrait/relation_internal.h

@@ -30,6 +30,7 @@
 #include "arrow/result.h"
 #include "arrow/util/macros.h"
 
+// GH-44954: silence [[deprecated]] declarations in protobuf-generated code
 ARROW_SUPPRESS_DEPRECATION_WARNING
 #include "substrait/algebra.pb.h"  // IWYU pragma: export
 ARROW_UNSUPPRESS_DEPRECATION_WARNING

cpp/src/arrow/engine/substrait/test_plan_builder.cc

@@ -33,6 +33,7 @@
 #include "arrow/type_fwd.h"
 #include "arrow/util/macros.h"
 
+// GH-44954: silence [[deprecated]] declarations in protobuf-generated code
 ARROW_SUPPRESS_DEPRECATION_WARNING
 #include "substrait/algebra.pb.h"  // IWYU pragma: export
 ARROW_UNSUPPRESS_DEPRECATION_WARNING

cpp/src/arrow/engine/substrait/util_internal.h

@@ -27,6 +27,7 @@
 #include "arrow/util/macros.h"
 #include "arrow/util/unreachable.h"
 
+// GH-44954: silence [[deprecated]] declarations in protobuf-generated code
 ARROW_SUPPRESS_DEPRECATION_WARNING
 #include "substrait/algebra.pb.h"  // IWYU pragma: export
 #include "substrait/plan.pb.h"     // IWYU pragma: export

cpp/src/arrow/flight/sql/protocol_internal.cc

@@ -16,6 +16,7 @@
 
 #include "arrow/util/macros.h"
 
+// GH-44954: silence [[deprecated]] declarations in protobuf-generated code
 ARROW_SUPPRESS_DEPRECATION_WARNING
 #include "arrow/flight/sql/protocol_internal.h"