Skip to content

Commit 828d18e

Browse files
committed
ARROW-5388: [Go] use arrow.TypeEquals in array.NewChunked
Author: Sebastien Binet <binet@cern.ch> Closes #4362 from sbinet/issue-5388 and squashes the following commits: cb50f87 <Sebastien Binet> ARROW-5388: use arrow.TypeEquals in array.NewChunked
1 parent 68329e7 commit 828d18e

File tree

2 files changed

+23
-1
lines changed

2 files changed

+23
-1
lines changed

go/arrow/array/table.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ func NewChunked(dtype arrow.DataType, chunks []Interface) *Chunked {
117117
dtype: dtype,
118118
}
119119
for i, chunk := range chunks {
120-
if chunk.DataType() != dtype {
120+
if !arrow.TypeEquals(chunk.DataType(), dtype) {
121121
panic("arrow/array: mismatch data type")
122122
}
123123
chunk.Retain()

go/arrow/array/table_test.go

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,28 @@ func TestChunked(t *testing.T) {
112112
}
113113
}
114114

115+
func TestChunkedEqualDataType(t *testing.T) {
116+
mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
117+
defer mem.AssertSize(t, 0)
118+
119+
lb1 := array.NewListBuilder(mem, arrow.PrimitiveTypes.Int32)
120+
defer lb1.Release()
121+
122+
v1 := lb1.NewArray()
123+
defer v1.Release()
124+
125+
lb2 := array.NewListBuilder(mem, arrow.PrimitiveTypes.Int32)
126+
defer lb2.Release()
127+
128+
v2 := lb2.NewArray()
129+
defer v2.Release()
130+
131+
c1 := array.NewChunked(arrow.ListOf(arrow.PrimitiveTypes.Int32), []array.Interface{
132+
v1, v2,
133+
})
134+
defer c1.Release()
135+
}
136+
115137
func TestChunkedInvalid(t *testing.T) {
116138
mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
117139
defer mem.AssertSize(t, 0)

0 commit comments

Comments
 (0)