Revert to NDEBUG because it's a standard define in release builds in MSVC

Change-Id: Ia4031fd71ff615c16f4d2e07675727385e28e82f

Author: wesm

cpp/cmake_modules/SetupCxxFlags.cmake

@@ -80,7 +80,7 @@ endif()
 if (NOT MSVC)
   set(CXX_FLAGS_DEBUG "-ggdb -O0")
   set(CXX_FLAGS_FASTDEBUG "-ggdb -O1")
-  set(CXX_FLAGS_RELEASE "-O3 -DARROW_NDEBUG")
+  set(CXX_FLAGS_RELEASE "-O3 -DNDEBUG")
 endif()
 
 set(CXX_FLAGS_PROFILE_GEN "${CXX_FLAGS_RELEASE} -fprofile-generate")

cpp/src/arrow/allocator-test.cc

@@ -46,7 +46,7 @@ TEST(stl_allocator, FreeLargeMemory) {
 
   uint8_t* data = alloc.allocate(100);
 
-#ifndef ARROW_NDEBUG
+#ifndef NDEBUG
   EXPECT_EXIT(alloc.deallocate(data, 120), ::testing::ExitedWithCode(1),
               ".*Check failed: \\(bytes_allocated_\\) >= \\(size\\)");
 #endif

cpp/src/arrow/ipc/metadata.cc

@@ -774,7 +774,7 @@ Status WriteFileFooter(const Schema& schema, const std::vector<FileBlock>& dicti
   flatbuffers::Offset<flatbuf::Schema> fb_schema;
   RETURN_NOT_OK(SchemaToFlatbuffer(fbb, schema, dictionary_memo, &fb_schema));
 
-#ifndef ARROW_NDEBUG
+#ifndef NDEBUG
   for (size_t i = 0; i < dictionaries.size(); ++i) {
     DCHECK(BitUtil::IsMultipleOf8(dictionaries[i].offset)) << i;
     DCHECK(BitUtil::IsMultipleOf8(dictionaries[i].metadata_length)) << i;

cpp/src/arrow/ipc/writer.cc

@@ -188,7 +188,7 @@ class RecordBatchSerializer : public ArrayVisitor {
                int64_t* body_length) {
     RETURN_NOT_OK(Assemble(batch, body_length));
 
-#ifndef ARROW_NDEBUG
+#ifndef NDEBUG
     int64_t start_position, current_position;
     RETURN_NOT_OK(dst->Tell(&start_position));
 #endif
@@ -202,7 +202,7 @@ class RecordBatchSerializer : public ArrayVisitor {
     RETURN_NOT_OK(WriteMetadataMessage(batch.num_rows(), *body_length, &metadata_fb));
     RETURN_NOT_OK(WriteMessage(*metadata_fb, dst, metadata_length));
 
-#ifndef ARROW_NDEBUG
+#ifndef NDEBUG
     RETURN_NOT_OK(dst->Tell(&current_position));
     DCHECK(BitUtil::IsMultipleOf8(current_position));
 #endif
@@ -228,7 +228,7 @@ class RecordBatchSerializer : public ArrayVisitor {
       }
     }
 
-#ifndef ARROW_NDEBUG
+#ifndef NDEBUG
     RETURN_NOT_OK(dst->Tell(&current_position));
     DCHECK(BitUtil::IsMultipleOf8(current_position));
 #endif

cpp/src/arrow/memory_pool-test.cc

@@ -47,7 +47,7 @@ TEST(DefaultMemoryPoolDeathTest, FreeLargeMemory) {
   uint8_t* data;
   ASSERT_OK(pool->Allocate(100, &data));
 
-#ifndef ARROW_NDEBUG
+#ifndef NDEBUG
   EXPECT_EXIT(pool->Free(data, 120), ::testing::ExitedWithCode(1),
               ".*Check failed: \\(bytes_allocated_\\) >= \\(size\\)");
 #endif

cpp/src/arrow/table-test.cc

@@ -459,7 +459,7 @@ TEST_F(TestRecordBatch, Equals) {
   ASSERT_FALSE(b1.Equals(b4));
 }
 
-#ifdef ARROW_NDEBUG
+#ifdef NDEBUG
 // In debug builds, RecordBatch ctor aborts if you construct an invalid one
 
 TEST_F(TestRecordBatch, Validate) {

cpp/src/arrow/util/logging.h

@@ -47,7 +47,7 @@ namespace arrow {
               : ::arrow::internal::FatalLog(ARROW_FATAL) \
                     << __FILE__ << __LINE__ << " Check failed: " #condition " "
 
-#ifdef ARROW_NDEBUG
+#ifdef NDEBUG
 #define ARROW_DFATAL ARROW_WARNING
 
 #define DCHECK(condition)      \
@@ -83,7 +83,7 @@ namespace arrow {
 #define DCHECK_GE(val1, val2) ARROW_CHECK((val1) >= (val2))
 #define DCHECK_GT(val1, val2) ARROW_CHECK((val1) > (val2))
 
-#endif  // ARROW_NDEBUG
+#endif  // NDEBUG
 
 namespace internal {