From 705e04bb15f481e476c9e7a8e2ac92460890ad0c Mon Sep 17 00:00:00 2001 From: Edward Visel <1693477+alistaire47@users.noreply.github.com> Date: Tue, 17 Jan 2023 12:10:52 -0600 Subject: [PATCH] GH-33726: [CI][Go] Set host name in Go benchmarks (#33728) Closes #33726; see issue for comprehensive explanation. cc @ zeroshade ### Rationale for this change Go benchmarks are sending host names from runners that vary slightly, preventing us from seeing the full history of the benchmarks on Conbench. ### What changes are included in this PR? Sets host name in Go benchmarks via environment variable so benchmark history will be available on Conbench. ### Are these changes tested? Yes, for the benchadapt code that will pick it up: https://github.com/conbench/conbench/blob/main/benchadapt/python/tests/test_result.py#L107-L114 ### Are there any user-facing changes? No * Closes: #33726 Authored-by: Edward Visel <1693477+alistaire47@users.noreply.github.com> Signed-off-by: Jacob Wujciak-Jens --- .github/workflows/go.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 2e973a2c7096d..2c6eb6db0f324 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -96,6 +96,7 @@ jobs: CONBENCH_EMAIL: ${{ secrets.CONBENCH_EMAIL }} CONBENCH_PASSWORD: ${{ secrets.CONBENCH_PASS }} CONBENCH_REF: ${{ github.ref_name }} + CONBENCH_MACHINE_INFO_NAME: amd64-debian-11 run: | pip install benchadapt@git+https://github.com/conbench/conbench.git@main#subdirectory=benchadapt/python python ci/scripts/go_bench_adapt.py @@ -266,6 +267,7 @@ jobs: CONBENCH_EMAIL: ${{ secrets.CONBENCH_EMAIL }} CONBENCH_PASSWORD: ${{ secrets.CONBENCH_PASS }} CONBENCH_REF: ${{ github.ref_name }} + CONBENCH_MACHINE_INFO_NAME: amd64-macos-11 run: | pip install benchadapt@git+https://github.com/conbench/conbench.git@main#subdirectory=benchadapt/python python ci/scripts/go_bench_adapt.py