PR feedback

Author: nealrichardson

appveyor.yml

@@ -105,7 +105,7 @@ environment:
       PATH: '%GOPATH%\bin;%GOROOT%\bin;%PATH%'
     - JOB: "R without libarrow"
       USE_CLCACHE: false
-  
+
   MSVC_DEFAULT_OPTIONS: ON
   APPVEYOR_SAVE_CACHE_ON_ERROR: true
 
@@ -155,22 +155,22 @@ for:
     NOT_CRAN: true
 
   artifacts:
-    - path: '*.Rcheck\**\*.log'
+    - path: 'r\*.Rcheck\**\*.log'
       name: Logs
 
-    - path: '*.Rcheck\**\*.out'
+    - path: 'r\*.Rcheck\**\*.out'
       name: Logs
 
-    - path: '*.Rcheck\**\*.fail'
+    - path: 'r\*.Rcheck\**\*.fail'
       name: Logs
 
-    - path: '*.Rcheck\**\*.Rout'
+    - path: 'r\*.Rcheck\**\*.Rout'
       name: Logs
 
-    - path: '\*_*.tar.gz'
+    - path: 'r\*_*.tar.gz'
       name: Bits
 
-    - path: '\*_*.zip'
+    - path: 'r\*_*.zip'
       name: Bits
 
 # Disable test discovery

r/configure.win

@@ -25,20 +25,22 @@ if [ "$ARROW_R_DEV" == "TRUE" ]; then
 fi
 
 VERSION=$(grep ^Version DESCRIPTION | sed s/Version:\ //)
+# Try to find/download a C++ Arrow binary
 "${R_HOME}/bin${R_ARCH_BIN}/Rscript.exe" "tools/winlibs.R" $VERSION
-
+# If binary not found, script exits nonzero
 if [ $? -ne 0 ]; then
+  # We'll have to install without libarrow. Note to the user how to rectify.
   echo "------------------------- NOTE ---------------------------"
   echo "After installation, please run arrow::install_arrow() to install"
   echo "required runtime libraries"
   echo "---------------------------------------------------------"
 else
+  # Set the right flags to point to and enable arrow/parquet
   RWINLIB="../windows/arrow-${VERSION}"
   PKG_CFLAGS="-I${RWINLIB}/include -DARROW_STATIC -DPARQUET_STATIC -DARROW_R_WITH_PARQUET -DARROW_R_WITH_ARROW"
   PKG_LIBS="-L${RWINLIB}/lib"'$(subst gcc,,$(COMPILED_BY))$(R_ARCH) '"-L${RWINLIB}/lib"'$(R_ARCH) '"-lparquet -larrow -lthrift -lboost_regex-mt-s -ldouble-conversion -lz -lws2_32"
 fi
 
-# Write to Makevars
 echo "*** Writing Makevars.win"
 sed -e "s|@cflags@|$PKG_CFLAGS|" -e "s|@libs@|$PKG_LIBS|" src/Makevars.in > src/Makevars.win
 # Success