Tweaks

Change-Id: I04a99b218bb38e0472d71414898840e6f6d8cf7f

Author: wesm

cpp/CMakeLists.txt

@@ -114,7 +114,7 @@ CHECK_CXX_COMPILER_FLAG("-maltivec" CXX_SUPPORTS_ALTIVEC)
 
 # compiler flags that are common across debug/release builds
 #  - Wall: Enable all warnings.
-set(CXX_COMMON_FLAGS "-std=c++11 -Wall -Werror")
+set(CXX_COMMON_FLAGS "-std=c++11 -Wall")
 
 # Only enable additional instruction sets if they are supported
 if (CXX_SUPPORTS_SSE3 AND ARROW_SSE3)

cpp/src/arrow/ipc/json-internal.h

@@ -40,6 +40,8 @@ using RjWriter = rj::Writer<rj::StringBuffer>;
 namespace arrow {
 namespace ipc {
 
+// TODO(wesm): Only exporting these because arrow_ipc does not have a static
+// library at the moment. Better to not export
 Status ARROW_EXPORT WriteJsonSchema(const Schema& schema, RjWriter* json_writer);
 Status ARROW_EXPORT WriteJsonArray(
     const std::string& name, const Array& array, RjWriter* json_writer);

cpp/src/arrow/types/list-test.cc

@@ -46,6 +46,7 @@ TEST(TypesTest, TestListType) {
   ListType list_type(vt);
   ASSERT_EQ(list_type.type, Type::LIST);
 
+  ASSERT_EQ(list_type.name(), string("list"));
   ASSERT_EQ(list_type.ToString(), string("list<item: uint8>"));
 
   ASSERT_EQ(list_type.value_type()->type, vt->type);