Skip to content

Commit 68329e7

Browse files
committed
ARROW-5325: [Archery][Benchmark] Output properly formatted jsonlines from benchmark diff cli command
Author: Krisztián Szűcs <szucs.krisztian@gmail.com> Closes #4274 from kszucs/hook-test and squashes the following commits: 2be8098 <Krisztián Szűcs> remove arm intrinsics headers 3c8deb1 <Krisztián Szűcs> __ARM_NEON__ is legacy 20e4850 <Krisztián Szűcs> clang-format 55d2c77 <Krisztián Szűcs> intrinsics 29bded6 <Krisztián Szűcs> clang format f1f4f92 <Krisztián Szűcs> remove intrinsics include 35f6468 <Krisztián Szűcs> arm intrinsics de8389d <Krisztián Szűcs> write line separator to output properly formatted jsonlines
1 parent 81e4013 commit 68329e7

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

cpp/src/arrow/compute/kernels/aggregate-benchmark.cc

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,16 @@
1818
#include "benchmark/benchmark.h"
1919

2020
#include <vector>
21-
#ifdef _MSC_VER
22-
#include <intrin.h>
23-
#else
24-
#include <immintrin.h>
25-
#endif
2621

2722
#include "arrow/builder.h"
28-
#include "arrow/memory_pool.h"
29-
#include "arrow/testing/gtest_util.h"
30-
#include "arrow/testing/random.h"
31-
#include "arrow/util/bit-util.h"
32-
3323
#include "arrow/compute/benchmark-util.h"
3424
#include "arrow/compute/context.h"
3525
#include "arrow/compute/kernel.h"
3626
#include "arrow/compute/kernels/sum.h"
27+
#include "arrow/memory_pool.h"
28+
#include "arrow/testing/gtest_util.h"
29+
#include "arrow/testing/random.h"
30+
#include "arrow/util/bit-util.h"
3731

3832
namespace arrow {
3933
namespace compute {

dev/archery/archery/cli.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,9 +352,12 @@ def benchmark_diff(ctx, src, preserve, suite_filter, benchmark_filter,
352352

353353
regressions = 0
354354
runner_comp = RunnerComparator(runner_cont, runner_base, threshold)
355+
356+
# TODO(kszucs): test that the output is properly formatted jsonlines
355357
for comparator in runner_comp.comparisons:
356358
regressions += comparator.regression
357359
json.dump(comparator, output, cls=JsonEncoder)
360+
output.write('\n')
358361

359362
sys.exit(regressions)
360363

0 commit comments

Comments
 (0)