Skip to content

Commit 3a2dfba

Browse files
laurentgowesm
authored andcommitted
ARROW-101: Fix java compiler warnings
Fixes several warnings emitted by java compiler regarding the use of raw types and unclosed resources. Author: Laurent Goujon <laurent.goujon@online.fr> Closes #60 from laurentgo/laurent/fix-generic-warnings and squashes the following commits: 96ccc67 [Laurent Goujon] [ARROW-101] Fix java compiler resources warnings 61bde83 [Laurent Goujon] [ARROW-101] Fix java compiler rawtypes warnings
1 parent 356d015 commit 3a2dfba

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

java/vector/src/main/java/org/apache/arrow/vector/ZeroVector.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import io.netty.buffer.ArrowBuf;
2121

22+
import java.util.Collections;
2223
import java.util.Iterator;
2324

2425
import org.apache.arrow.memory.BufferAllocator;
@@ -109,8 +110,8 @@ public TransferPair getTransferPair(BufferAllocator allocator) {
109110
// }
110111

111112
@Override
112-
public Iterator iterator() {
113-
return Iterators.emptyIterator();
113+
public Iterator<ValueVector> iterator() {
114+
return Collections.emptyIterator();
114115
}
115116

116117
@Override

java/vector/src/main/java/org/apache/arrow/vector/complex/impl/PromotableWriter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,16 +85,16 @@ private void setWriter(ValueVector v) {
8585
state = State.SINGLE;
8686
vector = v;
8787
type = v.getField().getType().getMinorType();
88-
Class writerClass = BasicTypeHelper
88+
Class<?> writerClass = BasicTypeHelper
8989
.getWriterImpl(v.getField().getType().getMinorType(), v.getField().getDataMode());
9090
if (writerClass.equals(SingleListWriter.class)) {
9191
writerClass = UnionListWriter.class;
9292
}
93-
Class vectorClass = BasicTypeHelper.getValueVectorClass(v.getField().getType().getMinorType(), v.getField()
93+
Class<?> vectorClass = BasicTypeHelper.getValueVectorClass(v.getField().getType().getMinorType(), v.getField()
9494
.getDataMode());
9595
try {
96-
Constructor constructor = null;
97-
for (Constructor c : writerClass.getConstructors()) {
96+
Constructor<?> constructor = null;
97+
for (Constructor<?> c : writerClass.getConstructors()) {
9898
if (c.getParameterTypes().length == 3) {
9999
constructor = c;
100100
}

java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringArrayList.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public boolean equals(Object obj) {
4242
if (!(obj instanceof List)) {
4343
return false;
4444
}
45-
List other = (List) obj;
45+
List<?> other = (List<?>) obj;
4646
return this.size() == other.size() && this.containsAll(other);
4747
}
4848

java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringHashMap.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public boolean equals(Object obj) {
4646
if (!(obj instanceof Map)) {
4747
return false;
4848
}
49-
Map other = (Map) obj;
49+
Map<?, ?> other = (Map<?, ?>) obj;
5050
if (this.size() != other.size()) {
5151
return false;
5252
}

0 commit comments

Comments
 (0)