PR comments

Author: jonkeane

cpp/src/arrow/compute/light_array_internal.cc

@@ -611,13 +611,9 @@ Status ExecBatchBuilder::AppendSelected(const std::shared_ptr<ArrayData>& source
           });
     Visit(source, num_rows_to_append - num_rows_to_process, row_ids + num_rows_to_process,
           [&](int i, const uint8_t* ptr, int32_t num_bytes) {
-            uint64_t* dst = reinterpret_cast<uint64_t*>(
-                target->mutable_data(2) +
-                offsets[num_rows_before + num_rows_to_process + i]);
-            const uint64_t* src = reinterpret_cast<const uint64_t*>(ptr);
-            uint8_t* dst_bytes = reinterpret_cast<uint8_t*>(dst);
-            const uint8_t* src_bytes = reinterpret_cast<const uint8_t*>(src);
-            memcpy(dst_bytes, src_bytes, num_bytes);
+            auto dst = target->mutable_data(2) +
+                       offsets[num_rows_before + num_rows_to_process + i];
+            memcpy(dst, ptr, num_bytes);
           });
   }
 

cpp/src/arrow/compute/row/compare_internal.cc

@@ -282,7 +282,7 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper(
       result_or |= tail_mask & (key_left ^ key_right);
     }
     int result = result_or == 0 ? 0xff : 0;
-    result = (length_left == length_right) ? result : 0;
+    result *= (length_left == length_right ? 1 : 0);
     match_bytevector[i] = result;
   }
 }