Unify API for writing column chunks / row groups in parallel #8582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 11, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
👏 -- thank you @adamreeve -- this looks perfect
I have nothing to add
| impl ArrowRowGroupWriterFactory { | ||
| #[cfg(feature = "encryption")] | ||
| fn new<W: Write + Send>( | ||
| /// Create a new [`ArrowRowGroupWriterFactory`] for the provided file writer and Arrow schema |
alamb
reviewed
Oct 15, 2025
|
|
||
| /// Converts this writer into a lower-level [`SerializedFileWriter`] and [`ArrowRowGroupWriterFactory`]. | ||
| /// This can be useful to provide more control over how files are written. | ||
| #[deprecated( |
Contributor
There was a problem hiding this comment.
I know I suggested deprecating this method 😞 , but after testing downstream with DataFusion I think we should not deprecate this method, for reasons listed on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Simplify API surface and only provide one way to write column chunks and row groups in parallel.
What changes are included in this PR?
ArrowRowGroupWriterFactoryconstructor public and simplify it to remove arguments that are available from theSerializedFileWriter.ArrowColumnWriterexample and test code to use theArrowRowGroupWriterFactory.parquet::arrow::arrow_writer::get_column_writersandparquet::arrow::arrow_writer::ArrowWriter::into_serialized_writerAre these changes tested?
Yes, covered by existing tests.
Are there any user-facing changes?
Yes, this deprecates existing public methods.