Use more compact Debug formatting of Field #8424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Sep 23, 2025
|
|
||
| let mut s = f.debug_struct("Field"); | ||
|
|
||
| if name != "item" { |
There was a problem hiding this comment.
this makes sense not to print the "standard" item naame
|
I am marking it as "api change" so it shows up in the release notes, and since we are going to do a major release next anyways (that can have breaking changes) this looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Despite us having
Displayimplementations forDataType, a lot of error messages still useDebug. See for instance:Displayformatting ofDataType:s in error messages datafusion#17565DisplayforDataTypeandField#8290Therefor I want to make sure the
Debugformatting ofField(and, by extension,DataType) is not utterly horrible. This PR makes things… slightly better.What changes are included in this PR?
Omits fields of
Fieldthat have their "default" values.Are these changes tested?
Yes, there are new tests.
Are there any user-facing changes?
Though this changes the
Debugformatting, I would NOT consider this a breaking change, because nobody should rely on consistentDebugformatting. See for instance https://doc.rust-lang.org/std/fmt/trait.Debug.html#stability