Add Decimal type support to arrow-avro #7832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced Decimal128 and Decimal256 mapping for Avro Decimal types. - Added parsing logic for Decimal attributes including precision, scale, and size. - Enhanced codec handling to convert Avro fixed or binary logical types into Arrow Decimal arrays. - Implemented `Decoder` support for reading and decoding Decimal data. - Added unit tests for Decimal128 and Decimal256 decoding with various configurations. - Updated `criterion` to version `0.6.0`.
alamb
approved these changes
Jul 1, 2025
| @@ -732,4 +838,122 @@ mod tests { | |||
| assert_eq!(list_arr.len(), 1); | |||
| assert_eq!(list_arr.value_length(0), 0); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_decimal_decoding_fixed256() { | |||
There was a problem hiding this comment.
I don't really have any way to verify that this is doing the right thing (like I don't know / have any way to verify if row1 and row2 byte arrays are valid avro)
One thing I suggest (in a different PR) is starting to test that the reader will work "end to end". Specifically, at least these two cases:
- Testing reading avro files written with other implementations
- Test "round tripping" arrow data from Arrow --> Avro --> Arrow and ensuring the same data has arrived
@jecsand838 have you considered this type of testing?
There was a problem hiding this comment.
@alamb That's a solid call out. I'll introduce those types of tests in my next PR for enum types.
|
Thanks again @jecsand838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of Add Avro Support #4886
Related to Avro codec enhancements #6965
Rationale for this change
This PR addresses a feature gap by introducing support for the Avro
decimallogical type, which is currently unimplemented as indicated by thetest_decimal_logical_type_not_implementedtest case. Thedecimaltype is crucial for handling precise numerical data common in financial and scientific applications, making this a necessary addition for broader Avro compatibility.What changes are included in this PR?
This PR introduces the necessary changes to both parse and decode the Avro
decimallogical type into the corresponding ArrowDecimal128orDecimal256data types.The main changes are:
Schema Parsing (
codec.rs):make_data_typeto correctly parse thedecimallogical type from the Avro schema.Codecenum'sDecimalvariant now correctly stores the precision, scale, and optional fixed-size from the schema's attributes.Decoding Logic (
record.rs):Decoder::Decimal128andDecoder::Decimal256variants to handle decoding of decimal values from bothbytesandfixedAvro types.Are these changes tested?
This PR includes comprehensive tests to validate the new functionality:
test_decimal_logical_type_not_implementedtest has been replaced with concrete test cases.record.rs(test_decimal_decoding_fixed256,test_decimal_decoding_fixed128,test_decimal_decoding_bytes_with_nulls, etc.) to cover various scenarios, including:fixedandbytesprimitive types.Decimal128andDecimal256.Are there any user-facing changes?
N/A