[Not for Merge] PoC implementation of PARQUET-2249: Introduce IEEE 754 total order #7408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Apr 17, 2025
parquet/src/basic.rs
Outdated
| @@ -841,6 +873,7 @@ impl From<parquet::LogicalType> for LogicalType { | |||
| parquet::LogicalType::BSON(_) => LogicalType::Bson, | |||
| parquet::LogicalType::UUID(_) => LogicalType::Uuid, | |||
| parquet::LogicalType::FLOAT16(_) => LogicalType::Float16, | |||
| parquet::LogicalType::VARIANT(_) => LogicalType::Variant, | |||
There was a problem hiding this comment.
it is probably valuable in itself to get a PR ready to upgrade the format spec (to get support for the Variant logical type, among other things)
3 tasks
|
There is an updated proposal here: I filed a ticket to track making a POC for that proposal here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
PoC implementation of PARQUET-2249 (apache/parquet-format#221).
What changes are included in this PR?
Adds ability to sort floating point statistics with IEEE 754 total order, now allowing
NaNto appear in column chunk and page index statistics.This is a proof of concept to aid in proving the utility of the changes to the Parquet specification in apache/parquet-format#221.
Are there any user-facing changes?
Yes.