Skip to content

Remove test_private_bucket object_store test #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Remove test_private_bucket object_store test #6601

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cecc361
Fix `test_private_bucket` test
alamb Oct 20, 2024
46a8e0a
remove test
alamb Oct 20, 2024
cb692c9
Merge remote-tracking branch 'apache/master' into alamb/fix_object_st…
alamb Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions object_store/src/aws/resolve.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,6 @@ pub async fn resolve_bucket_region(bucket: &str, client_options: &ClientOptions)
mod tests {
use super::*;

#[tokio::test]
async fn test_private_bucket() {
Copy link
Member

@findepi findepi Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR description says "Fix test_private_bucket object_store test"
and "Change to use another s3 bucket"

let's maybe update both before merge

Copy link
Contributor Author

@alamb alamb Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Thank you

let bucket = "bloxbender";

let region = resolve_bucket_region(bucket, &ClientOptions::new())
.await
.unwrap();

let expected = "us-west-2".to_string();

assert_eq!(region, expected);
}

#[tokio::test]
async fn test_bucket_does_not_exist() {
let bucket = "please-dont-exist";
Expand Down
Loading